Merged
Conversation
mantepse
force-pushed
the
combinatorial_log
branch
from
39d4e6b to
7175062
Compare
|
Documentation preview for this PR (built with commit 6bc8742; changes) is ready! 🎉 |
Merged
Collaborator
|
Conflicts here too. |
tscrim
approved these changes
Jun 26, 2025
Collaborator
tscrim
left a comment
tscrim
left a comment
There was a problem hiding this comment.
LGTM modulo one trivial thing. Once addressed or ignored, you can set a positive review.
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Collaborator
|
Danke! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 27, 2025
sagemathgh-40129: combinatorial log Implement the combinatorial logarithm as proposed by Labelle 2013. fixes sagemath#40112, fixes sagemath#40131 dependencies: sagemath#38544 URL: sagemath#40129 Reported by: Martin Rubey Reviewer(s): Travis Scrimshaw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the combinatorial logarithm as proposed by Labelle 2013.
fixes #40112, fixes #40131
dependencies: #38544